Merged
Conversation
duncanista
reviewed
Mar 4, 2025
duncanista
reviewed
Mar 4, 2025
duncanista
reviewed
Mar 4, 2025
duncanista
approved these changes
Mar 4, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Looks good – I'd simplify the metric creation logic just like we did for logs and traces, I'll double check if the Go Agent validates the URLs in some way
duncanpharvey
pushed a commit
that referenced
this pull request
Mar 10, 2026
* feat: logs_config_logs_dd_url * feat: apm pci endpoints * feat: metrics * feat: support metrics using dogstatsd methods * fix: use the right var * tests: use server url override * feat: refactor into flusher method * feat: clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580
Also adds support for TCP proxies (they use the same config so I extended it for metrics).
Verified this manually (although it's covered by automated tests) because you need a special Datadog Org (and thus API key) to use PCI endpoints. Will share org ID in slack.
Logs:
Traces: